search

FND / jslint-reporter

Node.js wrapper for JSLint
30 stars 7 forks source link

Make output compatible with VisualStudio #6

Closed johnp3d closed 11 years ago

johnp3d commented 11 years ago

This small change to formatOutput in wrapper.js changes output formatting so that in VisualStudio, you can double-click on an warning/error to jump to the line in the code.

//var line = [filepath, error.line, error.character, error.reason].join(":"); // format for VisualStudio var line = [ filepath + "(" + error.line + ")", error.character, error.reason].join(":");

FND commented 11 years ago

Thanks for highlighting this issue.

However, the current format was chosen because it was deemed the most conventional (though I can't actually find any useful reference for this right now) - so implementing your suggested change would break other tools.

I suppose we could make the error format configurable via a command-line option - would that work for you?

johnp3d commented 11 years ago

Hi! I wasn't sure if my message was sent, so I'm pleasantly surprised to see your response. A command line option would definitely work. Thanks, ~John

Date: Sat, 20 Jul 2013 05:55:57 -0700 From: notifications@github.com To: jslint-reporter@noreply.github.com CC: johnp3d@hotmail.com Subject: Re: [jslint-reporter] Make output compatible with VisualStudio (#6)

Thanks for highlighting this issue.

However, the current format was chosen because it was deemed the most conventional (though I can't actually find any useful reference for this right now) - so implementing your suggested change would break other tools.

I suppose we could make the error format configurable via a command-line option - would that work for you?

— Reply to this email directly or view it on GitHub.

FND commented 11 years ago

should be done with dc71a5bc2669c736adc2ffb0315d4d861abbcf7f - please confirm and close

johnp3d commented 11 years ago

Works like a charm. Thanks!

Date: Wed, 24 Jul 2013 07:16:25 -0700 From: notifications@github.com To: jslint-reporter@noreply.github.com CC: johnp3d@hotmail.com Subject: Re: [jslint-reporter] Make output compatible with VisualStudio (#6)

should be done with 2a8a00b - please confirm and close

— Reply to this email directly or view it on GitHub.