search

FNF-CNE-Devs / CodenameEngine

awesome fnf engine :D
Apache License 2.0
248 stars 166 forks source link

Add array option type #241

Closed bctix closed 7 months ago

bctix commented 7 months ago

adds an array option type :)

https://github.com/FNF-CNE-Devs/CodenameEngine/assets/51544115/5454da64-c460-40d6-afba-b3ea8815eb68

lunarcleint commented 7 months ago

This is a REALLY nice pull request, we've been meaning to add this for awhile. Just can you explain why you chose to use the inner data of the xml attributes instead of using the original data structure? It clashes with the rest of the xml

bctix commented 7 months ago

This is a REALLY nice pull request, we've been meaning to add this for awhile. Just can you explain why you chose to use the inner data of the xml attributes instead of using the original data structure? It clashes with the rest of the xml

Ne_Eo asked me to structure the xml like that.

lunarcleint commented 7 months ago

Me and Ne_Eo talked about it and if you change it back we will merge you pull request :D, sorry for the time loss 😭

lunarcleint commented 7 months ago

thank you for cool pull :D