Closed Jamextreme140 closed 6 months ago
thats not the getter and setter is, we meant the one that haxe gives you as possibility want me to make a commit to your pr to help ya?
thats not the getter and setter is, we meant the one that haxe gives you as possibility want me to make a commit to your pr to help ya?
Thanks, but now I think I got it. Check the last commit. (Note: Already tested and works fine)
oh ye you did it :D though i think itd be better if you added __audioSource only for the new openfl, so like do the compiler check and its good :D
I don't know what did you meant with that.
The reason of this PR is because the overriden openfl.media.SoundChannel
class in source has conflict with the installed library on haxelib (in case you decide to upgrade it), specifically I got this error: FlxSound.hx:[...] openfl.media.SoundChannel has no field "__audioSource"
hmm alr then lets leave it like that, you tested everything right?
Yeah, it compiles and game running fine. (I always test before commit)
great then, just tested aswell, looks great :D tysm for ur time on the enginee
great then, just tested aswell, looks great :D tysm for ur time on the enginee
My pleasure :3
(reopen of #249 with a new solution)
Uses (compiles) "source" or "audioSource" variable depending of the OpenFL version, in order to not break FlxSound.