FNF-CNE-Devs / CodenameEngine

awesome fnf engine :D
Apache License 2.0
248 stars 166 forks source link

FunkinParentDisabler: Prevents camera movement, shaking, and update flash #257

Closed EstoyAburridowGH closed 5 months ago

EstoyAburridowGH commented 5 months ago

Well, as the title mentions, this is a simple change to the FunkinParentDisabler class, which makes it so that when you are, for example, in the pause menu, the camera, in addition to stopping following, stops shaking and stops updating the flash

NexIsDumb commented 5 months ago

ooo the idea sounds good :D tmr we should also merge the dev repo of cne so i'll surely test this pr out after that and merge it if everything is good :D

NexIsDumb commented 5 months ago

OKAY I can finally merge this im sorry it took me almost 2 weeks😭 tyy :D

NexIsDumb commented 5 months ago

uh oh it seems this pr is causing issues in the pause menu (or anywhere the funkinparentdisabler got used) for example if you try to resize the windows in the pause menu the cameras wont resize, we might revert this and make each thing toggable instead prob image

EstoyAburridowGH commented 5 months ago

:sob: