FNF-CNE-Devs / CodenameEngine

awesome fnf engine :D
Apache License 2.0
253 stars 172 forks source link

File and folder organization #279

Open doggogit opened 5 months ago

doggogit commented 5 months ago

Hi, first PR here, wanted to do a clean-up, both folder and file wise.

Changes

If you wish for any files to be returned or if you feel like adjustments can be made, just make a comment or leave a review. I'll be sure to take a look. Cheers.

NeeEoo commented 5 months ago

keep generateDocs.bat since we use a seperate repo where we store the docs since its cleaner that way

NeeEoo commented 5 months ago

and im not a fan of the movement of the shell scripts cne and update since ppl might get confused

NexIsDumb commented 5 months ago

I would also avoid putting stuff in a docs folder because thats what the docsUpdate.bat needs whenever we have to update the pages repository

doggogit commented 5 months ago

keep generateDocs.bat since we use a seperate repo where we store the docs since its cleaner that way

Will return it, give me a minute

doggogit commented 5 months ago

and im not a fan of the movement of the shell scripts cne and update since ppl might get confused

Should I return them to the root folder or do you have any other ideas?

doggogit commented 5 months ago

I would also avoid putting stuff in a docs folder because thats what the docsUpdate.bat needs whenever we have to update the pages repository

Fair enough, I could rename the folder to something else

doggogit commented 5 months ago

I'll wait until you guys decide where the shell scripts need to be, I personally dislike them being in the root folder, cause it's just kinda cluttered, but if you wish to keep it that way, then I'll put em there 👍

NexIsDumb commented 5 months ago

sure, we'll for sure tell you but you'll have to wait a little as we'll look through all the pull requests for good as soon as we finish the new update

doggogit commented 5 months ago

sure, we'll for sure tell you but you'll have to wait a little as we'll look through all the pull requests for good as soon as we finish the new update

Alright, don't mind waiting, take your time

NeeEoo commented 4 months ago

Please make the 2 files have the correct pemissions

NeeEoo commented 4 months ago

i also think this commit will have to be merged after the update is released

doggogit commented 4 months ago

Please make the 2 files have the correct pemissions

Which ones?

NeeEoo commented 4 months ago

The 2 shell files

NexIsDumb commented 3 months ago

@doggogit remove th commit that i reverted from the guy with the lib changes

doggogit commented 3 months ago

@doggogit remove th commit that i reverted from the guy with the lib changes

How do you remove commits like that... I have no clue

NexIsDumb commented 3 months ago

@doggogit remove th commit that i reverted from the guy with the lib changes

How do you remove commits like that... I have no clue

hold on

NexIsDumb commented 3 months ago

there ya go for reverting commits you can just right click a commit in github desktop and select revert changes in commit

doggogit commented 3 months ago

there ya go for reverting commits you can just right click a commit in github desktop and select revert changes in commit

Ah, alright, I don't use GitHub Desktop, but good to know 👍

NeeEoo commented 2 months ago
Skärmavbild 2024-08-03 kl  18 55 57

Can you move them back?

doggogit commented 2 months ago
Skärmavbild 2024-08-03 kl 18 55 57

Can you move them back?

Where to?

NeeEoo commented 2 months ago
Skärmavbild 2024-08-03 kl 18 55 57

Can you move them back?

Where to?

Back to original place

doggogit commented 2 months ago

Is this alright?