Holiday Mod Conversion Issues

EliteMasterEric commented 5 months ago

Issue Checklist

[x] I have properly named the issue
[x] I looked in issues/discussions, if my question was previously anwsered

What is the preset selected?

Charts only

What are the contents of the latest .log file? (if applicable)

fnf-porter-2024-05-23_00-57-12.log

See attached file, Github wouldn't let me embed a log in a comment!

What is missing?

Songs from Part 1 (such as Plum) parse and produce JSON, but this JSON is not a valid chart. The length field includes a string; I believe this mod is using an older Psych chart format where events were included in the chart data.

Zanta's sprites aren't imported since they're placed in a subdirectory of the characters folder. (Note that if you're testing this, you need to remove the placeholder easy/normal/hard difficulties from the chart and rename Mania to Hard to access the song from Freeplay properly)

Missing files checklist

[x] I have checked the converter supports these files
[x] I have checked both directories, the original and converted one, and they aren't in the converted one

Additional Context (if applicable)

Mod used: https://gamebanana.com/mods/344364

Demolition from Part 2 seemed to output fairly well for a song that's so dynamic. No errors, just a lot of visual tweaks to be playable (plus re-implementing all the mechanics! ehe)

P.S. Amazing tool! I love the vocal splitter a lot.

P.P.S. Nice issue form.

BombasticTom commented 5 months ago

Thank you! We're glad you like the tool. I'll try to make a fix as soon as I finish my classes for today

gusborg88 commented 5 months ago

alright, we'll probably have to add some prompts for that or other detectors. Also hi Eric

tposejank commented 5 months ago

This bug is caused by not ignoring notes with -1 noteData while converting a chart. The sustain length is usually Psych engine's event name. Noted

tposejank commented 5 months ago

(Note that if you're testing this, you need to remove the placeholder easy/normal/hard difficulties from the chart and rename Mania to Hard to access the song from Freeplay properly)

As an additional note, to access songs from Freeplay properly, position yourself on "Random" then use the arrow keys to change between all available difficulties, until your songs show up. I do not know if it is intended, but it works properly!

BombasticTom commented 5 months ago

Chart issue fixed, Legacy Events are skipped (for now). Going to see what I can do about Zanta and difficulties

MemTheBun commented 5 months ago

ELITE GOAT!!!!!!

FNF-Porter / Porter.py