search

FNNDSC / ChRIS_store

Backend for ChRIS plugin apps store
MIT License
11 stars 19 forks source link

Add Functionality To Reset A Forgotten Password As A User. #57

Open sherrif10 opened 2 years ago

sherrif10 commented 2 years ago

Currently there is no functionality to reset a given password when a user lost it , we need to add this functionality such that a user can easily reset the new password. cc @mairin @jennydaman

Aman-Jamshed commented 2 years ago

Hey @sherrif10 @jennydaman @mairin , I would like to work on this issue. Can you please elaborate on this and help me how to get started? I also submitted an application to Outreachy for the upcoming cohort, which is still pending approval but I would like to contribute in ChRIS project from today only.

jennydaman commented 2 years ago

Hello @Aman-Jamshed,

this is a very advanced topic, your interest in it is impressive!

Have you tried cloning the repo and running it yet? Once you feel a little familiar with the code base, let's talk about implementation of this feature.

Regarding the feature itself: if you want to reset a password, you'll have to either know your current password, or ask the admin to set a new password for you. This workflow can be improved. Most common solution out in the wild is to email the user a password reset link.

For email we could do several approaches:

  1. rely on a proprietary third-party email SaaS such as sendgrid (easier)
  2. stick with open-source, self-hosted software by running a local SMTP server (difficult)
Aman-Jamshed commented 2 years ago

Thanks @jennydaman Actually, I used SMTP to implement the ability to reset passwords in one of my side projects, so I figured I might be able to help with this problem. You are correct, however, that I should become familiar with the code base first and attempt to solve the simpler problems before moving on to this one.

DevBramz commented 2 years ago

@jennydaman , has anyone implemented this issue yet?I'll be happy to implement it if not, both in the ChrisUi and ChrisStore

jennydaman commented 2 years ago

@DevBramz please read my comment about this in a related issue: https://github.com/FNNDSC/ChRIS_ultron_backEnd/issues/413#issuecomment-1275551909

kindyluv commented 2 years ago

@jennydaman Please check the comments I left on FNNDSC/ChRIS_ultron_backEnd#413 (comment)