Performance: cornerstone dependency

FNNDSC / ChRIS_ui

UI for ChRIS

MIT License

52 stars 114 forks source link

Performance: cornerstone dependency #1062

Open jennydaman opened 4 months ago

jennydaman commented 4 months ago

This is not an important issue.

The cornerstone3D dependency causes large increase in build memory usage, and also slows down first page load even though cornerstone is not used on the "welcome" page.

jennydaman commented 4 months ago

According to benchmarks using Lighthouse:

767488091709881a05be8d1dad5f8e3fca45eec7 reaches "First Contentful Paint" in 6.1s
9a4d1f2a2293a15012a40f81d845b72a825517ce reached "First Contentful Paint" in 9.3s

PintoGideon commented 4 months ago

@jennydaman Thanks for reporting this. Will look into code-splitting and using the vendor chunks feature in vite to get this working.

jennydaman commented 4 months ago

@PintoGideon i think it’s more important to work on other bugs or features. Even though the first-load performance is bad, it doesn’t matter too much since the assets are all cached.