FNNDSC / ami

AMI Medical Imaging (AMI) JS ToolKit
https://fnndsc.github.io/ami/#viewers_upload
MIT License
714 stars 212 forks source link

[improvement] Read Opacity from Texture in 1D LUT for data shader #221

Open cancan101 opened 6 years ago

cancan101 commented 6 years ago

This: https://github.com/FNNDSC/ami/blob/4e256ca023717acecc95e7dfaf95f24566cd435a/src/shaders/shaders.data.fragment.js#L96-L97 should be updated to be consistency with vr: https://github.com/FNNDSC/ami/blob/4e256ca023717acecc95e7dfaf95f24566cd435a/src/shaders/shaders.vr.fragment.js#L99-L102

repost from: https://github.com/FNNDSC/ami/commit/24a0301afeda042da7be2771320baba0954e3e77#commitcomment-25666498

NicolasRannou commented 6 years ago

Thanks for opening all the issues - much easier to keep track of things this way