search

FNNDSC / ami

AMI Medical Imaging (AMI) JS ToolKit
https://fnndsc.github.io/ami/#viewers_upload
MIT License
721 stars 213 forks source link

Main Page Examples are Broken #295

Open meawoppl opened 6 years ago

meawoppl commented 6 years ago

Description

This link http://jsfiddle.net/gh/get/library/pure/fnndsc/ami/tree/master/lessons/00#run Is on the main page and ends up with a error 422?

Live Demo

Its in master above.

Steps to Reproduce

Follow the link

Expected Results

Loader example in jsfiddle as in the past.

Browsers Affected

Versions

NicolasRannou commented 6 years ago

Thanks for reporting, I suspect that the ami.js build file provides some features that jsfiddle doesn't support. One thing that may fix it is change the babel targets in https://github.com/FNNDSC/ami/blob/dev/.babelrc

to be tested

PtiLuky commented 6 years ago

With the 422 error, I have a "Js wrap is invalid" message. it seems that in demo.details _jswrap: onLoad is the problem ? A possible solution : (?)

js_wrap: l

https://github.com/jsfiddle/jsfiddle-issues/issues/949

I don't know how to try it (without control on it) (and why would it stop working without any change... ?)

NicolasRannou commented 6 years ago

@PtiLuky the fix you suggested works, can you please submit a PR?

kuige commented 6 years ago

lessons 00 is ok now, but the other lessons start from 01 are still broken, 422 error, "Js wrap is invalid"

zeigerpuppy commented 6 years ago

I can confirm, lesson 00 is working but the others still result in Js wrap is invalid error. OS X 10.11.6, Firefox v61.0.1

NicolasRannou commented 6 years ago

Will be fixed soon, once #dev is merged into master.

Then we will just work on the master branch for a faster development process.