search

FNNDSC / pman

A process management system written in python
MIT License
23 stars 33 forks source link

Made sure image data wasn't being written to memory #117

Closed betaredex closed 5 years ago

rudolphpienaar commented 5 years ago

hey @betaredex @danmcp --

So you reverted to the old pman and pfioh ?

I was working on accommodating both swift and non-swift cases for pfioh/pman -- I was actually seeing if I could get the "broken" pfioh working by replacing the swift calls. Do you think this is still worthwhile exploring?

danmcp commented 5 years ago

@rudolphpienaar Yes, I reverted the change while Elliot works through the issues. I didn't want to leave master in a broken state any longer. It is still reasonable to explore your improvement as well. Not sure how long you were expecting it to take.

rudolphpienaar commented 5 years ago

Yep, I agree with reverting -- also not wanted to have master in a broken state. I was testing some logic on my end on Elliot's code: essentially reverted the calls from swift_storage to using mount_dir -- there were some gotchas, but it looks like the storePut worked. I was checking the storeGet. I'll continue with local container builds of the whole system.

danmcp commented 5 years ago

@rudolphpienaar This is ready for a second look. Elliot and I believe the previous issues are worked through.

rudolphpienaar commented 5 years ago

ok -- I'll take a look. I'll actually build local docker images of the whole system and do manual testing.

On 06/05/2019 09:31, Dan McPherson wrote:

@rudolphpienaar This is ready for a second look. Elliot and I believe the previous issues are worked through.