Closed umohnani8 closed 6 years ago
Addresses issue https://github.com/redhat-university-partnerships/radiology/issues/45 @danmcp @ravisantoshgudimetla PTAL I can remove the print statements if they are not needed. I just think that they would be helpful to be in the logs for the user if something goes wrong.
@ravisantoshgudimetla I updated the code, PTAL.
@umohnani8 Seems something broke in tests. Can you please check that otherwise this LGTM.
@danmcp PTAL
Should be ready now, @ravisantoshgudimetla @danmcp PTAL.
Storage is hard coded to 5Gi for now, I think that should be something the user should be able to control, but can add that functionality in later.
@danmcp @ravisantoshgudimetla should the pvc deletion happen here https://github.com/FNNDSC/pman/blob/master/pman/pman.py#L1360? If so, how do I go about testing that? How do I call the def_Shutdown() function?
@ravisantoshgudimetla yup, been testing it on the MOC.
@umohnani8 This PR has a merge conflict
Updated the get_data logic. Tested the various failure and success cases. @ravisantoshgudimetla @danmcp PTAL.
@danmcp should be ready now.
@umohnani8 Please squash the commits and I am good to merge
@danmcp squashed commits.
If there are more than 1 pod, the init-container of one pod should download the data while the init-containers of the other pods wait. Once the data is downloaded the processing container of all the pods can access the data.
Signed-off-by: umohnani8 umohnani@redhat.com