FOAP-NetMind-2022 / beetlepush

Learn JavaScript array methods
https://beetlepush.vercel.app/
Mozilla Public License 2.0
4 stars 0 forks source link

Remove unused code and files #48

Closed omiras closed 1 year ago

omiras commented 2 years ago

Description

There are several files, functions and piece of code we don't really use. It would be nice to have a cleaner code so adding new features won't be so cumbersome.

Requirements

These pieces of code and files should be removed. Additionally, some files should be modified. The list is not limited and may include other suggestions.

Remove from code

As commented, please, be free to remove anything you figure out it's not used anymore.

Files should be removed

Files to be modified

victoriageeks commented 1 year ago

Hola, estoy con esta issue** image he conseguido que de se muestre 'caterpillar' image y para cuando detecte 'grass' o 'brackets' no me lo muestre, sin embargo en la consola me sale un error diciendo helpertext.hide() is not a function. He estado investigando y .hide() funciona con selectores, y helpertext es una variable. Mi problema esta en como ocultar esa variable, ya que cogiendo el selector $(.helper).hide() sigue mostrandose grass o brackets. Helpertext no se lee como undefined, el problema está en como ocultar la variable si se lee como grass o brackets. Sigo investigando

omiras commented 1 year ago

Hi @victoriageeks ,

Thank you for taking care of this issue.

The problem is that we really must remove the feature and later, in another issue, rebuild it from the ground up. Even if you manage to make it work, at the end of the day you are displaying boardMarkUp.

It may be helpful for this exercise but think about this one:

image

omiras commented 1 year ago

Hi @victoriageeks ,

Will you still work on this issue? If you can't spend any time on it, do not worry, I'll take it. I want to close this issue before moving to further improvements 😊

omiras commented 1 year ago

$ for FILE in images/misc/*; do grep -rni $FILE *.html *.js *.css; done

Provided you execute this command in public folder, it will iterate all over the names of the files in images/misc folder". For each file, check if it is included in any file with extension HTML , CSS or JS

Some bash commands allow us to check if a particular file is linked to another. We achieve this by combining "for" and "grep"