search

FOGProject / fog-client

A cross platform computer management client
GNU General Public License v3.0
108 stars 34 forks source link

Re-enable host service setting "Client Updater" #120

Open Sebastian-Roth opened 4 years ago

Sebastian-Roth commented 4 years ago

By the looks of things the host service setting "Client Updater" was meant to be used for updating from the old legacy client to the new client. It's been disabled within the fog-client as well as in the FOG server code since but never cleaned up.

I'd vote for a revival of that setting because people could possibly want to disable auto updating of the fog-client for some hosts or even globally for a good reason at some point.

Things to look at (because I have dug into it already):

mastacontrola commented 4 years ago

Client updater? So there’s 2 kinds of it. One is a global setting in fog settings. This is the one that enables the New client to upgrade if it sees a a version upgrade. Say for example, 0.11.16 to 0.11.17

I was not aware this was disabled somewhere.

The other is the legacy client. It wasn’t really an updater, per say, but allowed the client to receive updated and new modules in the form of DLLs or even the configuration file could be updated through this. This, of course, only worked with Windows XP and I earlier OSs.

There was no way to upgrade Legacy Client to New Client. Of course forgive me if I’m not fully understanding. I am of the believe the parts you’re referring to is from trying to port over the legacy settings.

Sebastian-Roth commented 4 years ago

Thanks for your comment on this. I really don't know for sure what I ran into here. Following a request in the forums to see if this is something we want to have in 1.5.8 I looked through all the "Service Settings" we have in the hosts' settings page. There I wondered about it saying "Client Updater" is for the old legacy client and so I started digging through the code to find out if that's true. On that way I figured that the FOG server drops the part on client updates when sending JSON data and that even if I enable that in the code that the new fog-client doesn't use the information.

But as mentioned above I could see this feature being interesting in different situations and so I opened this issue so we can discuss and maybe add it some time in the future. What do you think?