FOGProject / fogproject

An open source computer cloning & management system
https://fogproject.org
GNU General Public License v3.0
1.14k stars 222 forks source link

take out class PXe function of dhcpd.conf of subnet for permit at lea… #452

Closed cavazquez closed 2 years ago

cavazquez commented 2 years ago

…st two subnet with diferent gw and next-server.

Sebastian-Roth commented 2 years ago

@cavazquez Thanks for bringing this up. Having the class definitions within the subnet block is probably just a relict from old times. We just didn't bother about changing it as it has been working great for many years.

Citing Sten Carlsen's post on the official mailinglist

[...] AFAIK class statements are global in nature [...]

Before we merge your pull request I need to ask you to apply some minor changes to it:

Sebastian-Roth commented 2 years ago

@cavazquez Thanks! Merging this now.

Sebastian-Roth commented 2 years ago

@cavazquez This was an easy merge even though your changes were towards master branch. For further pull requests may I ask you to do them on dev-branch directly. Thanks again!