search

FOGProject / fogproject

An open source computer cloning & management system
https://fogproject.org
GNU General Public License v3.0
1.08k stars 216 forks source link

FIX #567 ldap plugin with PHP 8 #570

Closed tomamplius closed 11 months ago

tomamplius commented 11 months ago

see #567

Sebastian-Roth commented 11 months ago

@tomamplius Thanks for sending in the PR. I am wondering if there is a nicer way to just check if "this" is a valid LDAP connection object instead of catching any TypeError exception. But on the other hand it seems like it has been like this for a long time using the "@" notation and so I am fine with this fix.

But I need to change the base branch to "dev-branch" as this is the one we collect all such changes in before merging into master.