FOGProject / fos

FOG Operating System
31 stars 33 forks source link

Partclone 0.3.12 doesn't capture raw images #35

Closed Sebastian-Roth closed 4 years ago

Sebastian-Roth commented 4 years ago

People in the forums report that capturing raw images doesn't work the way it used to (1, 2).

Sebastian-Roth commented 4 years ago

For yet unknown reasons querying the partition/disk size was disabled in partclone's ddclone.c. While this doesn't break partclone.dd as the device size is being set in dd mode (opt.ddd) this change does break partclone.imager!

Sebastian-Roth commented 4 years ago

After not hearing back from Mr Tsai and discussing this with @mastacontrola and @Quazz we better add our own patch for now to have 0.3.12 work properly for us - see 8b60ec0.

Closing this for now. We might re-open as soon as we have a proper or better solution to this.

mastacontrola commented 4 years ago

I still feel like we need to do: https://github.com/FOGProject/partclone/commit/bcd1a6ae6972b9215586ce7b2d71a7d997840a34

The arguments should be compiled as well. Maybe not as important but I still think it would help ensure the options ddclone is expecting are actually available.

Sebastian-Roth commented 4 years ago

I think #elif DD makes it to not be part of partclone.imager which we use. Calling partclone.dd is a different story. I wouldn't use it if imager works correctly.