search

FOGProject / fos

FOG Operating System
32 stars 34 forks source link

Add secure erase for SSDs #41

Closed abulhol closed 3 years ago

abulhol commented 4 years ago

See: https://github.com/FOGProject/fos/issues/40 I haven't been able to test it yet, because I don't have a machine with an SSD at hand, but will so so soon. If you have the chance, try it out.

wayneworkman commented 4 years ago

We definitely need to test this code before merging. Also need to validate this actually is a secure wipe in all cases where it would be selected.

abulhol commented 4 years ago

@wayneworkman I will let you know what my tests say - do you have the time and setup where you can test this anytime soon? As you saw in the commit, I don't differentiate between "fast", "normal" and "full" wipe for secure erase, as it does not make sense. So the info in the web UI would need to be updated as well then. What do you mean by

Also need to validate this actually is a secure wipe in all cases where it would be selected

?

abulhol commented 4 years ago

Testing shows that the updated fog.wipe does not break anything, but secure erase does not work at least on Intel NUCs, because the disk is "frozen". See more information in my Github issue https://github.com/FOGProject/fos/issues/40

Sebastian-Roth commented 4 years ago

@abulhol @mastacontrola I am wondering if we should still merge this into the official code.

mastacontrola commented 4 years ago

I’m assuming the “fallback” is to use shred/dd if the drive is frozen and/or doesn’t support secure erase?

If that’s the case I don’t see why we shouldn’t merge this in.

If an ssd does support and is not frozen, why do a drive intensive operation that takes much longer and potentially puts a lot of unnecessary wear on the disk?

abulhol commented 4 years ago

I am happy if you merge my changes. @mastacontrola I can also make another commit with the changes you suggested, or do you want to do that then?

Sebastian-Roth commented 3 years ago

@mastacontrola Seems like we lost track of this. @abulhol Would you mind adding another commit as requested?

abulhol commented 3 years ago

I am too busy at the moment, will make a new commit when I find the time.

Sebastian-Roth commented 3 years ago

@abulhol Just wondering if you'd want to get into this again?

abulhol commented 3 years ago

@Sebastian-Roth not really, no.