Closed rluzuriaga closed 1 year ago
I accidentally synced the fork after the main code commit so there is a commit for the merge. Not sure how to remove it or if it makes any issues.
@Neustradamus Thanks but the merge commit doesn't actually appear when I try that
@rluzuriaga said:
I accidentally synced the fork after the main code commit so there is a commit for the merge. Not sure how to remove it or if it makes any issues.
Don't worry. When merging this we'll just do a "Squash and merge" for it to be a single commit in the end.
@Sebastian-Roth said:
I just figured we have disk space alerting when saving a partition to the server fails as well - but I think having the pre-flight check is great! (https://github.com/FOGProject/fos/blob/master/Buildroot/board/FOG/FOS/rootfs_overlay/usr/share/fog/lib/funcs.sh#L2234 and also line 2260)
That makes sense, I'll add it to the PR later today.
@Sebastian-Roth I think I understood your comment wrong. I see in line 2234 and line 2260 this code:
Server Disk Space Available: $(df -h /images | awk '{print $4}')
That is pretty much what I am checking for, it just displays it differently. My implementation only displays the space. (ex. 0M, 100M, 10G) The code that is already there in those lines prints out this:
Avail
0
It looks like this:
I can change those 2 lines to look like this instead:
The difference is not huge but maybe it's a good idea to standardize this. That being said I will change the wording so that it all matches.
Added check for the total size, used space, used space percentage, and available space for the mounted share.
Added check for the available space in the mounted share when handling the
prepareUploadLocation
failureResolves #60