search

FOGProject / fos

FOG Operating System
30 stars 33 forks source link

Update kernelx64.config to support UFS #78

Closed darksidemilk closed 7 months ago

darksidemilk commented 8 months ago

UFS support for microsoft surface go 4 in x64 kernel Enabled UFSHCDPCI driver to support universal flash storage on PCI devices See also https://forums.fogproject.org/topic/17112/surface-go-4-incompatible/3?=1699986746721

darksidemilk commented 7 months ago

My first test I enabled that one, the PCI one in the pull as well as the top level "platform" option. It worked, I just then tested down to just PCI to get the minimal requirement to have the disk recognized and imaged in fog. I have no objections to including the bcg and or subsystem options. Our past documentation mentions limiting modules added to the kernel to keep maintenance simple, so I tried to follow that.

Looking at that tool, if we add it to fos for full debugging support, then I would add the bcg and platform options yes.

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Rodrigo Luzuriaga @.> Sent: Saturday, November 18, 2023 6:37:18 PM To: FOGProject/fos @.> Cc: JJ Fullmer @.>; Mention @.> Subject: [External]Re: [FOGProject/fos] Update kernelx64.config to support UFS (PR #78)

@rluzuriaga commented on this pull request.

In configs/kernelx64.confighttps://github.com/FOGProject/fos/pull/78#discussion_r1398304978:

@@ -3085,7 +3085,7 @@ CONFIG_MMC_MTK=y CONFIG_SCSI_UFSHCD=y

CONFIG_SCSI_UFS_BSG is not set

@darksidemilkhttps://github.com/darksidemilk Have you checked if adding CONFIG_SCSI_UFS_BSG gives you any positive, or negative, results? From the little I've researched, this config may need to be enabled for us to use ufs-toolhttps://github.com/westerndigitalcorporation/ufs-utils, which is probably the tool we'll need to use to fully support UFS.

— Reply to this email directly, view it on GitHubhttps://github.com/FOGProject/fos/pull/78#pullrequestreview-1738526496, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB3CO3GCONQ5ZBBAXD5X52TYFFPE5AVCNFSM6AAAAAA7LMVYX2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZYGUZDMNBZGY. You are receiving this because you were mentioned.Message ID: @.***>

darksidemilk commented 7 months ago

I also intend to update the compile fos kernel doc with whatever we add to the config

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Rodrigo Luzuriaga @.> Sent: Saturday, November 18, 2023 6:37:18 PM To: FOGProject/fos @.> Cc: JJ Fullmer @.>; Mention @.> Subject: [External]Re: [FOGProject/fos] Update kernelx64.config to support UFS (PR #78)

@rluzuriaga commented on this pull request.

In configs/kernelx64.confighttps://github.com/FOGProject/fos/pull/78#discussion_r1398304978:

@@ -3085,7 +3085,7 @@ CONFIG_MMC_MTK=y CONFIG_SCSI_UFSHCD=y

CONFIG_SCSI_UFS_BSG is not set

@darksidemilkhttps://github.com/darksidemilk Have you checked if adding CONFIG_SCSI_UFS_BSG gives you any positive, or negative, results? From the little I've researched, this config may need to be enabled for us to use ufs-toolhttps://github.com/westerndigitalcorporation/ufs-utils, which is probably the tool we'll need to use to fully support UFS.

— Reply to this email directly, view it on GitHubhttps://github.com/FOGProject/fos/pull/78#pullrequestreview-1738526496, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB3CO3GCONQ5ZBBAXD5X52TYFFPE5AVCNFSM6AAAAAA7LMVYX2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZYGUZDMNBZGY. You are receiving this because you were mentioned.Message ID: @.***>

rluzuriaga commented 7 months ago

@darksidemilk I just wanted to check if anything broke from your testing with that option enabled, especially because I don't have a machine with UFS to test. I agree that we should keep the enabled options to the minimum required, so I don't plan on enabling bsg unless we need it in the future.

darksidemilk commented 7 months ago

Nothing broke with that option enabled on the ufs device. The drive was recognized with and without it. I haven't yet tested it on other devices though. I plan to first thing tomorrow

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Rodrigo Luzuriaga @.> Sent: Sunday, November 19, 2023 4:56:41 PM To: FOGProject/fos @.> Cc: JJ Fullmer @.>; Mention @.> Subject: [External]Re: [FOGProject/fos] Update kernelx64.config to support UFS (PR #78)

@darksidemilkhttps://github.com/darksidemilk I just wanted to check if anything broke from your testing with that option enabled, especially because I don't have a machine with UFS to test. I agree that we should keep the enabled options to the minimum required, so I don't plan on enabling bsg unless we need it in the future.

— Reply to this email directly, view it on GitHubhttps://github.com/FOGProject/fos/pull/78#issuecomment-1818021453, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB3CO3D5ZHQ62M43EVGI3VDYFKMDHAVCNFSM6AAAAAA7LMVYX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJYGAZDCNBVGM. You are receiving this because you were mentioned.Message ID: @.***>

darksidemilk commented 7 months ago

I have confirmed that there are not problems with Non-UFS hardware with this added to the kernel as far as I have found. However, the surface go4 ufs drive is defaulting to a 4k block size, so images captured from say a vmware VM that has a 512e block size are note booting once deployed.