FOI-Bioinformatics / flextaxd

FlexTaxD (Flexible Taxonomy Databases) - Create, add, merge different taxonomy sources (QIIME, GTDB, NCBI and more) and create metagenomic databases (kraken2, ganon and more )
GNU General Public License v3.0
64 stars 7 forks source link

Fixed rank-issue on import from --mod_file #60

Closed jaclew closed 1 year ago

jaclew commented 1 year ago

Fixed rank-issue on import from --mod_file. It set the default rank to "-", now changed to "no rank". It then confused rank name and rank index when parsing the mod-file, it is now corrected.

jaclew commented 1 year ago

Put in context, this caused errors when dumping the flextaxd-database (--dump) where any nodes added using the --mod_file argument would not show up in nodes.dmp.

Suggestion: An error-printer should be implemented that warns the user when nodes can not be successfully written, such as when they have a rank that is undefined.