search

FOLIO-FSE / folio_migration_tools

A Python module and CLI tool that transforms legacy ILS data into the native FOLIO formats and loads it into FOLIO
MIT License
11 stars 9 forks source link

Update item_mapper to perform case-insensitive duplicate barcode detection for items #758

Closed bltravis closed 6 months ago

bltravis commented 6 months ago

Closes #738

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.94%. Comparing base (927072f) to head (718357a).

Files Patch % Lines
...n_tools/mapping_file_transformation/item_mapper.py 87.50% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #758 +/- ## ========================================== + Coverage 71.90% 71.94% +0.04% ========================================== Files 103 103 Lines 11392 11395 +3 Branches 1366 1366 ========================================== + Hits 8191 8198 +7 + Misses 2904 2901 -3 + Partials 297 296 -1 ``` | [Flag](https://app.codecov.io/gh/FOLIO-FSE/folio_migration_tools/pull/758/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FOLIO-FSE) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/FOLIO-FSE/folio_migration_tools/pull/758/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FOLIO-FSE) | `71.94% <94.11%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=FOLIO-FSE#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.