search

FOME-Tech / fome-fw

Free Open Motorsports ECU
https://www.fome.tech
Other
51 stars 29 forks source link

FOME console 92 instances of warning: [deprecation] #197

Open mi-hol opened 1 year ago

mi-hol commented 1 year ago

updated:

impact analysis in attached Spreadsheet warning_deprecation.ods

mi-hol commented 1 year ago

Affected are;

mi-hol commented 1 year ago
  • ANTLRInputStream in org.antlr.v4.runtime
  • NotNull in org.antlr.v4.runtime.misc

Reason for this seems usage of ANTLR (ANother Tool for Language Recognition) V 4.5 released Jan 23, 2015. The current version is V 4.13.0 released May 21, 2023

Affected files are:

  1. likely obsolete source file ( due to comment inside) /java_tools/configuration_definition/src/main/java/com/rusefi/RusefiParseErrorStrategy.java

  2. generated files: /java_console/ui/src/main/java/com/rusefi/livedata/generated/CPP14ParserBaseListener.java /java_console/ui/src/main/java/com/rusefi/livedata/generated/CPP14ParserListener.java

    as both contain comment:

// Generated from CPP14Parser.g4 by ANTLR 4.5

unclear yet how to fix this issue because the only content of readme.md is "See https://github.com/antlr/grammars-v4/tree/master/cpp" Would anyone have a hint?

mi-hol commented 1 year ago
  • RandomData in org.apache.commons.math3.random
  • RandomDataImpl in org.apache.commons.math3.random
  • isSupportUpperBoundInclusive() in RealDistribution from /org/apache/commons/math3/distribution
  • isSupportLowerBoundInclusive() in RealDistribution from /org/apache/commons/math3/distribution

Reason seems that source files from library org.apache.commons.math3.random have been directly copied into RE source tree.

as I just noticed RE seems to have fixed library org.apache.commons.math3.random issue via https://github.com/rusefi/rusefi/commit/3c38cfe4e8d746582d2ce882dd7f09752e9c4bd4

mck1117 commented 1 year ago

Apache commons math lib fixed in 67decbdd4cf78447f26c5da42fd7cd379b601079

mi-hol commented 1 year ago

now the new gradle seems to be the only source for deprecation warning :)

Configure project :ui
The AbstractArchiveTask.destinationDir property has been deprecated. This is scheduled to be removed in Gradle 8.0. Please use the destinationDirectory property instead. See https://docs.gradle.org/7.5.1/dsl/org.gradle.api.tasks.bundling.AbstractArchiveTask.html#org.gradle.api.tasks.bundling.AbstractArchiveTask:destinationDir for more details.
    at build_arh196x3twauwl53158hq[23](https://github.com/FOME-Tech/fome-fw/actions/runs/5607176588/jobs/10258082196#step:7:24)la$_run_closure3.doCall(/home/runner/work/fome-fw/fome-fw/java_console/ui/build.gradle:28)
    (Run with --stacktrace to get the full stack trace of this deprecation warning.)
mck1117 commented 1 year ago

now the new gradle seems to be the only source for deprecation warning :)

run ./gradlew clean then build and you'll see all the warnings for every file

mi-hol commented 1 year ago

run ./gradlew clean then build and you'll see all the warnings for every file

I lack the permission to perform this on the level org FOME builds, should this be added to the workflow definition?

mck1117 commented 1 year ago

all github actions happen in a fresh container - you only need that if building locally and have stale build intermediates

mck1117 commented 1 year ago

that's strange, I get warnings in a local build, but can't see them in the GHA builds

image

mi-hol commented 1 year ago

correct, I looked up this official FOME build (not local build) and saw no warnings

mck1117 commented 1 year ago

by the way, the same builds that run here are running in your fork: https://github.com/mi-hol/fome-fw/actions

mi-hol commented 1 year ago

he same builds that run here are running in your fork

yes, I enabled GHA in my fork to test workflow changes before opening a PR. Do you see issues with that?

mck1117 commented 1 year ago

Nope, that's completely fine, and in fact recommended. Your builds are completely separate from FOME, don't have access to FOME build secrets, etc.

mi-hol commented 1 year ago

strange, I get warnings in a local build, but can't see them in the GHA builds

just to be sure, will you look into fixing this or shall I learn gradle?

mi-hol commented 1 year ago

Apache commons math lib fixed in 67decbd

@mck1117 as I'm neither a JAVA nor Gradle expert, I wonder if maybe the same approach would work for com.devexperts.util ? It seems a clone of this code exists in fome-fw/java_console/logging-api/src/main/java/com/devexperts/util/

In case you confirm I'd be happy to eliminate it and search for similar cases

mi-hol commented 1 year ago

newest version of com.devexperts.logging.Logging is maintained on https://github.com/devexperts/QD/tree/master/dxlib/src/main/java/com/devexperts/logging

docs: https://docs.dxfeed.com/dxlib/api/overview-summary.html