search

FOME-Tech / fome-fw

Free Open Motorsports ECU
https://www.fome.tech
Other
51 stars 29 forks source link

Update fome_console.xml to use open-source JAVA distribution #216

Closed mi-hol closed 1 year ago

mi-hol commented 1 year ago

I would strongly advise to switch to an open-source distribution due to ORACLE changing their license to be non-free some time ago. Recommended is a version with long-time support (LTS)

nmschulte commented 1 year ago

Concur, though IIUC we're in the clear about the license (non-commercial). But yes, OpenJDK is the way IMO.

mck1117 commented 1 year ago

I'll actually push back on this a little - there's potential for "ordinary users" to end up in a weird state here if they get recommended to install non-Oracle Java with it already installed.

This file has no control over what JRE the console uses, only what the launcher will recommend if you don't have it installed.

mi-hol commented 1 year ago

there's potential for "ordinary users" to end up in a weird state

Would you mind to elaborate? I had multiple ORACLE and non-ORACLE JREs installed in the past, the only issue I remember was that "java.exe" used the version first found in PATH variable. Easy fix: specify the path for the desired version.