search

FOME-Tech / fome-fw

Free Open Motorsports ECU
https://www.fome.tech
Other
44 stars 22 forks source link

Leverage unused variable detection mechanism #295

Closed rusefillc closed 10 months ago

rusefillc commented 10 months ago

this repo has at least one (very minor) defect which would have been detected by unused-variable error had it not be disabled

https://github.com/rusefi/rusefi/commit/e78803b314a4829e58b6c911067a4e611ee1f4f0

mck1117 commented 10 months ago

what's the bug? why do you make a passive aggressive ticket instead of helping with the issue at hand?

rusefillc commented 10 months ago

Huh? You were tagged on https://github.com/rusefi/rusefi/commit/a07f82404a38d731a979498315a2771bb251ee62 yesterday

This issue is not about the bug but about leveraging tools which help us create better software. You know better than closing.

mck1117 commented 10 months ago

That was fixed 8 months ago: d36dfe4e07e6c00c26a3365fbe1bbabb0bbacbb0

Try and make issues useful - if there's a known fix, link the relevant commit/code/whatever instead of a cryptic warning..