console: try fix Simulator detect on Windows

[nmschulte]

attempts to improve, for https://github.com/FOME-Tech/fome-fw/issues/394

[rusefillc]

@nmschulte in what class is the "FOME Simulator program not found" error message defined?

[nmschulte]

@nmschulte in what class is the "FOME Simulator program not found" error message defined?

@rusefillc that comes from SimulatorExecHelper.getSimulatorBinary and is leveraged as the message in SimulatorHelper to put into Console.

• https://github.com/FOME-Tech/fome-fw/blob/master/java_console/io/src/main/java/com/rusefi/SimulatorExecHelper.java#L109
• https://github.com/FOME-Tech/fome-fw/blob/master/java_console/ui/src/main/java/com/rusefi/SimulatorHelper.java#L65

[rusefillc]

@nmschulte in what class is the "FOME Simulator program not found" error message defined?

OMG same constant name different values in different classes. Sad.

[nmschulte]

@nmschulte in what class is the "FOME Simulator program not found" error message defined?

OMG same constant name different values in different classes. Sad.

Yeah, would really like to address this comment at some point, especially if SimulatorFunctionalTestLauncher is no longer used or otherwise broken:

https://github.com/FOME-Tech/fome-fw/blob/master/java_console/ui/src/main/java/com/rusefi/SimulatorHelper.java#L21

    /**
     * this code start sumulator for UI console
     * todo: unify with the code which starts simulator for auto tests?
     */

https://github.com/FOME-Tech/fome-fw/blob/master/java_console/io/src/main/java/com/rusefi/SimulatorExecHelper.java#L21

    /**
     * This is currently used by auto-tests only. Todo: reuse same code for UI-launched simulator?
     */

[mck1117]

Has this been tested on Windows?

[nmschulte]

Has this been tested on Windows?

I had a friend test this on Windows, swapping in the fome_console.jar built from this branch in to the last release, and also confirmed that the snapshots since #378 do indeed fail: it works.