search

FOME-Tech / fome-fw

Free Open Motorsports ECU
https://www.fome.tech
Other
34 stars 17 forks source link

idle stepper TS panel disable should not depend ETB functions #426

Open nmschulte opened 1 month ago

nmschulte commented 1 month ago

it seems rusefi/rusefi#4904 may have been merged without thorough review

does this change make sense? configuring idle stepper hardware should not depend on ETB function/configuration, right?

rusEFI has the same logic yet: https://github.com/rusefi/rusefi/blob/master/firmware/tunerstudio/tunerstudio.template.ini#L3570 -- cc @rusefillc

also, perhaps still an issue exists if both ETB and idle stepper are trying to use the same hardware?

perhaps instead of this change, simply the condition should change from != to ==, and possibly moved to a higher order?

last, mind this comment? is this still applicable now that h-bridge panels are split w/ rusefi/rusefi#4904?

nmschulte commented 1 month ago

rusefi/rusefi#5972 seems to be this issue; via: https://rusefi.com/forum/viewtopic.php?p=49196#p49196 also: https://github.com/rusefi/rusefi/commit/ca301e1479b157635b95e9055ec98246a535b37a