FOME-Tech / fome-fw

Free Open Motorsports ECU
https://www.fome.tech
Other
44 stars 22 forks source link

Tachometer sweep does not work on CANbus tachometer #482

Closed rusefillc closed 1 week ago

rusefillc commented 1 week ago

https://github.com/FOME-Tech/fome-fw/commit/2ff394e3e9cd8fbf13e8d58633fead04acd48c21 does not work neither for existing CANbus dash profiles nor for Lua CANbus integration

mck1117 commented 1 week ago

And it's not really supposed to. We send the real values over CAN and allow the dash to do whatever it wants. If the dash is going to do a tach sweep, it does that internally, independent of the ECU.

rusefillc commented 1 week ago

So you signal fake RPM for one kind of dashes but not for the other kind of dashes, gotcha!