Simplify common role

[SuperQ]

• Use a handler for updating the apt cache.
• Move backports into the main sources.list.
• Simplify go_arch with a vars expansion instead of set fact tasks.

Signed-off-by: Ben Kochie superq@gmail.com

[markvdb]

Op wo 29 jan. 2020 om 15:02 schreef Paweł Krupa notifications@github.com:

@paulfantom commented on this pull request.

In ansible/playbooks/roles/common/tasks/configure_apt.yml https://github.com/FOSDEM/infrastructure/pull/258#discussion_r372398706:

-- name: "run apt update if we have modified the sources"

• apt:
• update_cache: true
• when: apt_sources.changed +- name: cleanup old backports config
• apt_repository:
• repo: "deb http://deb.debian.org/debian {{ ansible_distribution_release }}-backports main contrib non-free"

I think this will remove current backports as it depends on ansible variable, but I am not sure.

In case of any doubt, please don't make this kind of change at this point in time.

Kind regards,

Mark -- Mark Van den Borre Hogestraat 16 3000 Leuven, België +32 486 961726

[paulfantom]

@markvdb it is not me who created this PR and maybe author has no doubts that it works :) . I am just reviewing it and need explanation from @SuperQ as I see the same line is added in https://github.com/FOSDEM/infrastructure/pull/258/files#diff-ea8a784d3451dd6923172e130674fc1aR3

[SuperQ]

Verified that this does the right thing.