search

FOSDEM / infrastructure

Infrastructure used during the conference
Other
54 stars 21 forks source link

Show current status in API #278

Closed johanvdw closed 4 years ago

johanvdw commented 4 years ago

Note that this conflicts with the new way apikeys.php is set up . Also the extra mapping table from roomname to id should be avoided for next edition by setting the API names

The new files should also be copied, this is not yet here.

markvdb commented 4 years ago

Yes please, move this to the vault...

Op di 18 feb. 2020 om 14:34 schreef Wouter Verhelst < notifications@github.com>:

@yoe requested changes on this pull request.

In ansible/playbooks/roles/video-control-server/files/apikeys.php https://github.com/FOSDEM/infrastructure/pull/278#discussion_r380673125:

  • "k3401"=>"e006aba74a51d11a",
  • "k1105"=>"4c5739a15a8d9dc7",
  • "ud2218a"=>"2f797151fe1d8e48",
  • "k4201"=>"aa0b557e7b6fab13",
  • "ub2147"=>"04e570c920836646",
  • "ua2118"=>"26b50a85fd3978c7",
  • "ub4136"=>"91ac7e78f7c74f4f",
  • "k4401"=>"2e69f70b2d25018e",
  • "h2213"=>"862dc666e0201cc4",
  • "ua2114"=>"2d0bce3d5206830e",
  • "h2214"=>"e4dd7f5898f4cbf7",
  • "h2215"=>"4a35ad57643739af",
  • "ud2119"=>"69172ec14cd03dd8",
  • "ub2252a"=>"da0a8d954c83e446",
  • "ub5230"=>"348ed28d013111ec",
  • "ud2208"=>"5fdc1abf550d9fef",

If these are meant to be secret API keys, they should probably be in the ansible vault instead?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/FOSDEM/infrastructure/pull/278?email_source=notifications&email_token=AAF6ECEXBR336F6HMLX2CXLRDPPVNA5CNFSM4KOUOCGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCV5FMAI#pullrequestreview-360338945, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF6ECBEB7SITSND6LUPM23RDPPVNANCNFSM4KOUOCGA .

-- Mark Van den Borre Hogestraat 16 3000 Leuven, België +32 486 961726

johanvdw commented 4 years ago

Oops, it actually already is set up in vault, I was not aware I added this file again.

johanvdw commented 4 years ago

See code in https://github.com/FOSDEM/infrastructure/pull/261/commits/04143017881063768deec0c1a9c828dd9bdf3b25

I'll have to create new keys anyways as these were public.