search

FOSS-Cell-GECPKD / Price-Tracker

MIT License
2 stars 2 forks source link

front-end part created #3

Closed iamAravindks closed 4 years ago

anandbaburajan commented 4 years ago

@iamAravindks Hey! Congrats on your 2nd PR! I'm not checking out this PR yet. (reviewers can actually check out PRs on their local computers to try iit out) But a few suggestions:

  1. You can write a sentence or two about your PR in the PR description.
  2. Since your project has a server side too, you can put the client side React part in a new client folder.
  3. Try to go with React's functional components, as I mentioned in the group.
anandbaburajan commented 4 years ago

One more thing, the project doesn't need to look nice and cool from the beginning. You can just build a MVP: "A minimum viable product is a version of a product with just enough features to satisfy early customers and provide feedback for future product development."

You can open issues for the styling and other parts of less importance and someone else can work on it too! :D

anandbaburajan commented 4 years ago

Merging this PR after the discussion with @iamAravindks. Please do put these files in a new client directory later. Great work! :)