search

FOSS-Cell-GECPKD / Today

A simple personal daily journal and social platform
MIT License
2 stars 5 forks source link

added base UI of diary page #7

Closed jaisonjoshi closed 3 years ago

jaisonjoshi commented 3 years ago

@AnandBaburajan added the base UI of dairy page. please review the pr.

anandbaburajan commented 3 years ago

@jaisonjoshi Hey, why did you close the PR? Should I still review this?

jaisonjoshi commented 3 years ago

@AnandBaburajan The code climate showed an error that the function has exceeded the number of lines.

jaisonjoshi commented 3 years ago

I thought it would affect the pr...

anandbaburajan commented 3 years ago

The code climate showed an error that the function has exceeded the number of lines.

That's okay! It's not that huge of an error and you can just push another commit if you want to fix it. It's just a suggestion from CodeClimate that it would be better if your function was shorter (for readability, maintainability, etc)

anandbaburajan commented 3 years ago

@jaisonjoshi Did you delete your forked repository? We could have simply re-opened this PR. Please let me know your issues and doubts at the chatroom. :)

jaisonjoshi commented 3 years ago

i just edited my function ..but somehow I couldn't commit again... so i forked it again..

anandbaburajan commented 3 years ago

i just edited my function ..but somehow I couldn't commit again... so i forked it again..

Did you look into why you couldn't commit again? If you've doubts, feel free to let us know in the group and please try not to delete the forked repos if there are workarounds. :)

jaisonjoshi commented 3 years ago

okay ..I think it is because of whitespaces and after cleared and tried to commit, it says it is upto date...

jaisonjoshi commented 3 years ago

i made another pull request and code climate error again appeared.. there is still 31 lines.. :(

anandbaburajan commented 3 years ago

i made another pull request and code climate error again appeared.. there is still 31 lines.. :(

That's okay because the difference (31 - 25) is not that huge