FOSSASystems / FOSSASAT-1

GNU General Public License v3.0
536 stars 106 forks source link

Only LSB of batteryChargingCurrent is sent in RTTY #8

Open jgromes opened 4 years ago

jgromes commented 4 years ago

Due to a cast from int16_t to uint8_t, only LSB of charging current is sent during RTTY system info transmission:

https://github.com/FOSSASystems/FOSSASAT-1/blob/e9ca4d440e252bebd633d2d2d7eb15c7406ac2bc/Code/FossaSat1/communication.cpp#L282

Also, current RTTY system info prints out letter shift symbol at the end of each hex-encoded byte. This makes transmission longer than it needs to be (although easier to decode in some cases).