[Bug] Can't connect to ISPConfig 3

[ImmensumUniversum]

Describe the bug

When trying to establish a connection, I see an error "Server_Exception::__construct(): Argument FOSSBilling/FOSSBilling#2 ($variables) must be of type ?array, int given, called in /var/www/example.com/library/Server/Manager/Ispconfig3.php on line 541 (9998)"

How to reproduce

1. ISPConfig 3 installed on Debian 11
2. In FossBilling go to "Configuration" => "Hosting plans and servers" => "New Server" and enter all data
3. After creation try to modify server data or click button "Test connection"

Expected behavior

Tested the connection with HestiaCP in the same way - everything is OK

Screenshots

No response

FOSSBilling version

v0.3.0 stable

Module version

No response

Device

No response

Information

No response

Additional context

No response

[Wakk0]

Hi,

Same issue here

[jaapmarcus]

Soap login function of ISPConfig is completely broken. So it probably needs a complete rewrite

[admdly]

Soap login function of ISPConfig is completely broken. So it probably needs a complete rewrite

It looks like REST can now be used with the API, though it's difficult to check as they charge for the manual and I don't have enough of a need for it to be worth paying for.

Either way, if rewritten it would be great to move away from SOAP as we can then drop the soap PHP module requirement.

[jaapmarcus]

I have been able to login after creating a new remote user.

How ever it still breaks on multiple things

[willy2k69]

Here is the API documentation https://git.ispconfig.org/ispconfig/ispconfig3/-/tree/develop/remoting_client

EDIT

"Examples are provided for SOAP, why not for REST? The REST API supports all functions and can be exactly substituted for SOAP examples. For all functions, the request and response parameters are the same for SOAP and REST."

[lonelywoolf]

I'll look on it later. If anyone needs to test server instances (VPS) for develop this, we'll provide it for testing purposes.

[jsonkenyon]

Working on this, so far I have gotten the following up and running with the RestAPI

• Login to get a session for the API.
• Can create accounts, and if client doesn't exist in ISP it will create them.
• Suspend/Un-suspend accounts. (I don't think this is going to count for any resellers, I'm not 100% sure on ISPConfig, so if you know how that works LMK)

Looking over the code of the old system it looks like I have to do the following left.

• [x] 1. Create the DNS records for ISPConfig upon account creation
• [x] 2. Change Package (This doesn't look like it actually exists, current code base updates the USER not the PACKAGE.) It's also not listed in the API docs if we can update the limits of the plan that they are on.
• [x] 3. Cancel Account
• [x] 4. Change Account Password (Completed, and confirmed password is changing. However, ISPConfig doesn't allow to login with the new password. Might be a bug in ISPConfig itself, the ISPConfig client is getting the password updated from what I can see in the database)

[jsonkenyon]

Update

I just got done, adding and making sure that the DNS gets created. This marks the list as complete and I should have a pull request tomorrow to get it updated, and we will need some testers/feedback.

This is still a big change, and I'm looking at improving the code further. The goal of this round was just to get it working again, now its code cleanup, looking to see if we can add more features, and if we need to make further dns adds.

For now, its currently ~3am for me, so I'm going to bed :D

-------EDIT--------

After thought, it may be possible to actually get the package update working 🤔 either way, I'll do a pull request tomorrow to get this updated and I'll take a look at adding the package update.