search

FOSSBilling / ISPConfig-3

A community maintained ISPConfig 3 server manager for FOSSBilling
Apache License 2.0
2 stars 1 forks source link

Complete rewrite using REST #2

Closed jsonkenyon closed 6 months ago

jsonkenyon commented 6 months ago

This update rewrites the entire module and drops the SOAP API, and exchange for the REST API. Closes #1

concienciadesventurada commented 6 months ago

hi, FOSSBilling team!

I wanted to know if this can be implemented, this service has been unmaintained for the past few months, plain soap api in its current state is clunky at best

jsonkenyon commented 6 months ago

Todos, all completed and should be good to go. Let me know if you need a ISPConfig 3 setup, I'll see about getting one setup and provide you details over discord.

(I currently have mine running locally on my home lab server, in proxmox)

----EDIT Updated the commit message from Finished @ TODOS => Finished TODOS (which was force pushed) as it was tagging a user on github. whoops.

jsonkenyon commented 6 months ago

@BelleNottelling No problem, I'm happy to maintain it also if needed. There's some things I wanna get done, eg return types, further error handling, etc but for now the goal was to just get it working. Now that it does that I can focus on other things with it, I'm also still searching the api docs but it doesn't seem ISPConfig has an api endpoint for changing plan features.

BelleNottelling commented 6 months ago

@BelleNottelling No problem, I'm happy to maintain it also if needed. There's some things I wanna get done, eg return types, further error handling, etc but for now the goal was to just get it working. Now that it does that I can focus on other things with it, I'm also still searching the api docs but it doesn't seem ISPConfig has an api endpoint for changing plan features.

Sounds great!

I'm going to give about a week so other contributiors a chance to review the PR as well.

If no objections are mentioned before then, I'll merge this, update some info on the repo, link to it on our website, and announce it's fixed status via our discord & forum.

That's again for the contribution!

BelleNottelling commented 6 months ago

@jsonkenyon Thank you again for the rewrite and for offering to help maintain this integration!

I've merged your PR and published a release with your rewritten version. On top of that, I have sent you an invite to this repository as a maintainer so that you'll be able to help triage issues & have a generally smoother process maintaining it.

Cheers!