FOSSEE / OMChemSim

Chemical library developed using OpenModelica for steady-state and dynamic process simulation
BSD 3-Clause "New" or "Revised" License
37 stars 28 forks source link

Taking input for variable Base Component twice while simulating PFR #37

Closed nayakpriyam closed 4 years ago

nayakpriyam commented 4 years ago

While simulating the PFR example, It is noticed that the user has to give input for variable Base Component twice (once for Base_C and again for BC_r[Nr]).

The variable which is used to define "Base Component" in a reaction is defined twice: once in the kinetic reaction model (BC_r[Nr]) and once in the PFR model (Base_C). Also, the variable is declared once as an array(BC_r[Nr]) and again as an integer(Base_C). Since both these variables are used in the code, therefore they cannot be removed arbitrarily.

This leads to taking input from the user twice in two different forms for the same variable, which represents the base component. This conflict needs to be addressed.

image

RahulNagraj444 commented 4 years ago

Addressed through PR#40