pep8speaks
commented
2 years ago Hello @dilipboidya! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
- In the file
src/kicadtoNgspice/DeviceModel.py:
Line 257:1: E101 indentation contains mixed spaces and tabs Line 257:1: W191 indentation contains tabs Line 257:1: W293 blank line contains whitespace Line 258:1: W191 indentation contains tabs Line 259:1: W191 indentation contains tabs Line 259:2: E101 indentation contains mixed spaces and tabs Line 260:1: E101 indentation contains mixed spaces and tabs Line 319:1: E101 indentation contains mixed spaces and tabs Line 319:1: W191 indentation contains tabs Line 319:1: W293 blank line contains whitespace Line 320:1: W191 indentation contains tabs Line 322:1: E101 indentation contains mixed spaces and tabs Line 382:1: E101 indentation contains mixed spaces and tabs Line 382:1: W191 indentation contains tabs Line 382:1: W293 blank line contains whitespace Line 383:1: W191 indentation contains tabs Line 383:1: W293 blank line contains whitespace Line 384:1: W191 indentation contains tabs Line 384:1: W293 blank line contains whitespace Line 385:1: W191 indentation contains tabs Line 385:1: W293 blank line contains whitespace Line 395:1: W293 blank line contains whitespace Line 395:13: E101 indentation contains mixed spaces and tabs Line 395:13: W191 indentation contains tabs Line 564:1: W391 blank line at end of file
rahulp13
Related Issues
https://github.com/FOSSEE/eSim/tree/master/library/deviceModelLibrary One can see, in this section we have limited device/components, for example, we don't have RF diodes, Gunn diodes and other devices.
Purpose
Users can work and design various circuits that requires RF diodes, Gunn Diode, transmission lines, voltage controlled swich, MOSFETs, etc,.
With the complexity in designs and various applications of the users it is highly expected to have almost all the devices should available in the package so that it can help electronics circuit designers and enthusiasts to work on the project without thinking to model various devices.
Approach
The model editor window is helpful to model spice files of many devices. In fact, converting datasheets to spice model files are also possible, although it is a complex process and requires different tools. After getting device spice model files it is then tested for IV characteristics at a preferred temperature and simulated results are matched with the datasheets of the device, individually.
This can be of greater helpful for designers because they don't need to focus on modelling the device.