search

FOSSRIT / fossrit.github.io

Official website for Free and Open Source Software @ RIT MAGIC Center and FOSS academia
https://fossrit.github.io
Mozilla Public License 2.0
9 stars 12 forks source link

Update Open @ RIT Page and FOSS hours times #190

Closed Yiroh closed 7 months ago

Yiroh commented 7 months ago

Fix for Issue #188

MoralCode commented 7 months ago

This is a good start! I think it would ideally be nice to remove the entire page (i.e. the file you edited in this PR) and instead change the link in the navbar to go straight to the openr.it website (or whatever the canonical URL for them is)

Although i worry about losing the history of the text above what you edited (about OPEN@RIT being approved in 2020 by provost granberg)

Yiroh commented 7 months ago

Added the history back, and added a temporary history text file while I gather the history. Also in the first commit, I change the README to actually have steps on how to contribute and a link to the website this repository is for.

MoralCode commented 7 months ago

Added the history back, and added a temporary history text file while I gather the history. Also in the first commit, I change the README to actually have steps on how to contribute and a link to the website this repository is for.

Usually it's better to separate changes like this that are unrelated into another PR/branch to be considered separately.

Added the history back,

Sounds good! Did the runbook not have any useful info at all on it? it seems like thats the overarching infrastructure manual for FOSS@RIT stuff, may be useful to link to

Yiroh commented 7 months ago

Sounds good! Did the runbook not have any useful info at all on it? it seems like thats the overarching infrastructure manual for FOSS@RIT stuff, may be useful to link to

That is true, it would not hurt to link to it, though maybe have a disclaimer that information on that website may be outdated?

Yiroh commented 7 months ago

Usually it's better to separate changes like this that are unrelated into another PR/branch to be considered separately.

I honestly didn't know it was adding to this until I was already at commit 3... it was just doing it automatically... I'll make branches on my forked repository so it doesn't happen again.

MoralCode commented 7 months ago

Sounds good! Did the runbook not have any useful info at all on it? it seems like thats the overarching infrastructure manual for FOSS@RIT stuff, may be useful to link to

That is true, it would not hurt to link to it, though maybe have a disclaimer that information on that website may be outdated?

Would the disclaimer then be liable to become outdated itself though (i.e. if someone modernizes the runbook?) How far is too much? Idk

Id just say "heres the runbook/instructions for how to run things in case its useful" or something like that

Yiroh commented 7 months ago

Id just say "heres the runbook/instructions for how to run things in case its useful" or something like that

would that be fine to add into this PR? In addition to that, changing the meeting place, time, and day of the week? I know those are subject to change every semester...

MoralCode commented 7 months ago

would that be fine to add into this PR?

Sure!

In addition to that, changing the meeting place, time, and day of the week? I know those are subject to change every semester...

Idk how pedantic to be with this repo tbh. Larger projects will probably want to separate that into another PR to keep things separate/organized (heck, maybe it can be automated somehow), but yeah idk if I wanna make you go through all that if the change is just small/simple. That said it may be worth seeing if that small change leads to a larger change, like if the date is posted in several places (maybe excluding old blog posts?) unifying the date into one place like i did with the IRC link recentlyish (#178) may be a good PR to make separately

Yiroh commented 7 months ago

That said it may be worth seeing if that small change leads to a larger change, like if the date is posted in several places (maybe excluding old blog posts?) unifying the date into one place like i did with the IRC link recentlyish (#178) may be a good PR to make separately

So in the config.yml? That is currently where I did the changes... image

MoralCode commented 7 months ago

oh perfect, i didnt realize it was already modular like that

Yiroh commented 7 months ago

Alright, committed those changes to this PR. Done adding on to this PR unless something needs to be resolved.

MoralCode commented 7 months ago

is history.txt just notes or is that file intended to be a publicly viewable webpage?

Yiroh commented 7 months ago

just notes for now

Yiroh commented 7 months ago

Made the changes you suggested, will make a feature branch for history from now on