search

FOSSRIT / fossrit.github.io

Official website for Free and Open Source Software @ RIT MAGIC Center and FOSS academia
https://fossrit.github.io
Mozilla Public License 2.0
9 stars 12 forks source link

Add Calendar page #85

Closed ct-martin closed 4 years ago

ct-martin commented 4 years ago

Based on RITlug site calendar. I leave it to you to choose where to link (outside this PR).

jwflory commented 4 years ago

Thanks @ct-martin. I'll try to review this by the end of the week. I also requested review by the Tech Team since I am not particularly web-savvy.

Tjzabel commented 4 years ago

This is essentially verbatim the RITlug website PR that we merged a few days ago. You can see the merged view here.

I'll leave it to you guys to approve.

ct-martin commented 4 years ago

@jwflory

  1. I asked you offline at BrickHack, but calendar is based on well-formed metadata (frontmatter) of posts. Since this isn't specific to the calendar and is more of documentation on how to write a post, would you like it in README.md or CONTRIBUTING.md? Also, I am of the opinion that it's better to keep this information in the repo than the runbook due to the fact there there are implementation details in the explanations. See the RITlug README for what this would look like
  2. We've actually hit the limit of how much as can fit in the navbar, do you mind merging this and continuing the discussion in another PR? I doubt you want to remove anything, but adding dropdowns to the navbar will be beyond the scope of this PR. Screen Shot 2020-02-13 at 12 09 28
jwflory commented 4 years ago

Hey @ct-martin, could you please rebase this PR on the latest master branch? I'll document the how-to piece in the Runbook along with the other website content and we can move this PR along. Thanks for being patient.

ct-martin commented 4 years ago

@jwflory done. In particular, please note the date-start and date-end frontmatter when you're updating the runbook (this is in the RITlug docs)