search

FPGA-Research-Manchester / FABulous

Fabric generator and CAD tools
https://fabulous.readthedocs.io/en/latest/
Apache License 2.0
148 stars 34 forks source link

Workflow fail silently #147

Open KelvinChung2000 opened 9 months ago

KelvinChung2000 commented 9 months ago

After the changes in #130, the GitHub action will fail to detect errors during the execution of any command since the shell will catch the error and prevent it from propagating to the action. The GitHub action will require updates to avoid situations like this happening.

TaoBi22 commented 9 months ago

Good point! Any suggestions for how to do this? grepping for error messages seems a little fragile

KelvinChung2000 commented 9 months ago

Maybe we can remove the ./build_test_design.sh at the smoke test and force to use the synthesis result and the place and route result from the CLI.