search

FPGA-Research-Manchester / FABulous

Fabric generator and CAD tools
https://fabulous.readthedocs.io/en/latest/
Apache License 2.0
142 stars 31 forks source link

Exception messages not printed #148

Closed IAmMarcelJung closed 4 months ago

IAmMarcelJung commented 5 months ago

Since #130, the exception message are not printed in the shell anymore. Since we already have logging, the exception message might also not be need and could therefore be removed.

If we however need the messages, something like 

except Exception as e:
    print(e)
    return False

inside onecmd would again print the exception message. We should therefore decide if either omitting or printing the exception message is preferred.

IMHO it would be better to print the messages, but any other suggestions (also different ones to these two options) are welcome as always.

KelvinChung2000 commented 4 months ago

Printing the exception message will be better, as sometimes the cause of the error might be absent. Directly logging the error message will also be helpful.

KelvinChung2000 commented 4 months ago

fixed on #152