FPGA-Research-Manchester / FABulous

Fabric generator and CAD tools
https://fabulous.readthedocs.io/en/latest/
Apache License 2.0
148 stars 34 forks source link

Improve and fix problems in geometry generation #164

Closed JakobTernes closed 3 months ago

JakobTernes commented 8 months ago

This pull request adds functionality to the geometry_generator and fixes several problems:

Additions:

Fixes:

I will publish FABulator ( https://github.com/FPGA-Research-Manchester/FABulator ) in the next days. It is currently in its alpha stage and some instabilities and bugs are to be expected.

Btw, i hope this pull request doesn't cause chaos considering a lot is happening here right now...

mole99 commented 8 months ago

Exciting work! Yeah, there's a lot happening right now :D

Since you touched quite some lines, it probably makes sense to merge this before #163 and reapply the formatter on top of it. What do you think @KelvinChung2000?

KelvinChung2000 commented 8 months ago

I will review this first, then with FABulator and then do #163?

Dirk would like to do a 2.0 release, but I am unsure of the exact plan... We will need to clear up the image at some point; we at least need to know what should be included and what not. Otherwise, the release will be a mess.

JakobTernes commented 8 months ago

FABulator is now public.