Persistent command line history not working on FABulous2.0 branch

FPGA-Research-Manchester / FABulous

Fabric generator and CAD tools

https://fabulous.readthedocs.io/en/latest/

Apache License 2.0

148 stars 33 forks source link

Persistent command line history not working on FABulous2.0 branch #230

Open IAmMarcelJung opened 2 months ago

IAmMarcelJung commented 2 months ago

When testing the edits made in the recent pull requests, I noticed that the persistent CLI history (being able to recall commands from previous FABulous sessions) introduced in #132 did not work anymore in the FABulous2.0 branch. It still does work for me in the master branch. Can anyone confirm or deny this behaviour? If it can be confirmed, was it removed on purpose or by accident?

Thanks in advance for any help!

KelvinChung2000 commented 2 months ago

I have experienced the same, and it is likely by accident.

IAmMarcelJung commented 2 months ago

Thanks for your feedback, then it is a bug and should be fixed at some time. I do not have the time currently but if it will not be fixed for some time I might look into this. But since it's just a nice-to-have and nothing critical, it is not urgent.

Still, it shows that we might need better testing if features get broken by code updates. But I think this is already known and we just don't have the resources to do so.

KelvinChung2000 commented 2 months ago

When I am working on the release, I will spend some time using LLM to generate tests for the software.