search

FPGAwars / apio

:seedling: Open source ecosystem for open FPGA boards
https://github.com/FPGAwars/apio/wiki
GNU General Public License v2.0
772 stars 131 forks source link

Changed the behavior of the sim command to require --testbench flag if more than once benchmark is found. #343

Closed zapta closed 4 months ago

zapta commented 4 months ago

The main change in this PR is in the behavior of the apio sim command. Now, it exists with an error if the --testbench flag is not specified and more than one testbench is found. Also cleaned up the clean logic in the scones scripts and removed the remove a selection by default of ice40 architecture which bit me because of missing two verbose flags in the apio clean commands.

I tested as much as I could with ice40 and ecp5 architectures but could not test end to end due to lack of boards. Overall I feel good about these changes but if anything will come up in testing please ping me.

Obijuan commented 4 months ago

Thanks! I will test it on different boards during next weeks

zapta commented 4 months ago

Thanks!

Here is another small one. https://github.com/FPGAwars/apio/pull/344

On Tue, Feb 20, 2024 at 8:58 PM Juan Gonzalez-Gomez < @.***> wrote:

Thanks! I will test it on different boards during next weeks

— Reply to this email directly, view it on GitHub https://github.com/FPGAwars/apio/pull/343#issuecomment-1955896952, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQVMQK7GTJPRD7SPMIEEUTYUV5IPAVCNFSM6AAAAABDSDKLOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJVHA4TMOJVGI . You are receiving this because you authored the thread.Message ID: @.***>