search

FPGAwars / apio

:seedling: Open source ecosystem for open FPGA boards
https://github.com/FPGAwars/apio/wiki
GNU General Public License v2.0
794 stars 136 forks source link

`scons.py` - misorders `extra_args` to `dfu-util` #377

Closed benagricola closed 3 weeks ago

benagricola commented 5 months ago

Trying to program a pico-ice using apio upload, triggering dfu-util and receiving the following error:

(base) ➜  fpga git:(main) ✗ apio upload                                                                          
[Mon Apr 29 20:42:46 2024] Processing pico-ice
---
dfu-util -d 1209:b1c0 -a 0 -D --reset hardware.bin
Error: Unexpected argument: hardware.bin
Usage: dfu-util [options] ...

This is because the --reset argument is inserted between the -D arg and the build file.

My quick fix for this locally was to put the extra_args block above the args block but I don't know if this would cause issues with other programmers.

zapta commented 3 weeks ago

@Obijuan, I believe this can be closed. (I can't).

Obijuan commented 3 weeks ago

thanks @zapta ! :-)

Obijuan commented 3 weeks ago

@zapta I've given you rights to manage pull request and issues. Now you should be able to close issues opened by others. Thanks a lot for your work. You are on fire! :-)