FPGAwars / apio

:seedling: Open source ecosystem for open FPGA boards
https://github.com/FPGAwars/apio/wiki
GNU General Public License v2.0
794 stars 136 forks source link

Pylint seems to be disabled more than intended. #398

Open zapta opened 4 weeks ago

zapta commented 4 weeks ago

The APIO code include pylint directives that appear to relate to a single error or warning but in fact they disable the linting for adjacent statements as well (until the end of block?), potentially hiding additional errors or warnings.

    # R0913: Too many arguments (6/5)
    # pylint: disable=R0913
    def run(self, command, variables, packages, board=None, arch=None):
      .....
zapta commented 1 week ago

It seems taht pylint provide some control over the scope of the warnings suppression, as described at https://pylint.pycqa.org/en/latest/user_guide/messages/message_control.html

For example, the disable-next directive applies only to the next line.

# pylint: disable-next=dangerous-default-value