search

FPGAwars / apio

:seedling: Open source ecosystem for open FPGA boards
https://github.com/FPGAwars/apio/wiki
GNU General Public License v2.0
801 stars 138 forks source link

Changed the oss-cad-suite package definition to load the official FPGAwars release. #454

Closed zapta closed 1 week ago

zapta commented 1 week ago

After merging this request and updating your pip apio, run this to verify that indeed it's loaded from FPGAwars.

apio packages --install --verbose --force oss-cad-suite
cavearr commented 1 week ago

MErged! @zapta i need you configure your signed capatabilities in git,because i need to be very stricted with this in near future. Very soon i don't permit not signed pull request. This is very important the chatgpt use for a lot of users are generating a very complex situation around licenses and should be necesary implement a DCO very soon ( https://en.wikipedia.org/wiki/Developer_Certificate_of_Origin ) to avoid legal problems in near future.

cavearr commented 1 week ago

Hi @zapta , make tox are broken , could you review?

zapta commented 1 week ago

@cavearr

  1. I will set the signed capabilities.

  2. The make targets changed. You can see the Makefile for details.

The important ones are:

make lint                // Runs the linters
make test               // runs the tests
make check           // same as 'make lint' and 'make test'
make check_all     // Run 'make check' a few times, with different python versions.

I run 'make check_all' before sending pushing a commit but 'make check' should also be ok if you have only one python version installed.

BTW, the make check_all caught that @override is not available on older python version that apio supports so I took it off.

cavearr commented 1 week ago

Thanks! i'm review it and update the actions scripts.

Thanks!! i'm working in Icestudio now integrating your changes.

zapta commented 1 week ago

There is also apio developer info here https://github.com/FPGAwars/apio/blob/develop/DEVELOPER.md

On Tue, Nov 12, 2024 at 9:52 AM Carlos Venegas Arrabé < @.***> wrote:

Thanks! i'm review it and update the actions scripts.

Thanks!! i'm working in Icestudio now integrating your changes.

— Reply to this email directly, view it on GitHub https://github.com/FPGAwars/apio/pull/454#issuecomment-2471203975, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQVMQK3PM4RNUCOX3QZOLL2AI57VAVCNFSM6AAAAABRUSS32OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZRGIYDGOJXGU . You are receiving this because you were mentioned.Message ID: @.***>