FPtje / DarkRP

DarkRP, a non-serious roleplay gamemode for Garry's Mod.
https://darkrp.miraheze.org
MIT License
463 stars 710 forks source link

Ability to make your own door unlockable by a whole group #1413

Closed fantasticaneer closed 10 years ago

fantasticaneer commented 10 years ago

I've been in a situation many times where I've wanted to be able to allow everyone in my group to be able to enter a building, beit as the don of a mob, terrorist leader, owner of a restaurant, etc, there are many possible applications for this functionality and I think it's silly that it isn't built in already.

It'd simply be an addition to the F2 menu for door owning: "Add Group Ownership". You would then be able to set a job or multiple jobs as being owners of the door until you sell it, similar to how a group can own a door already.

This would make it so much easier to make bases without outside tools like fading doors and without constantly managing the list of allowed owners to add/remove people as they change jobs.

Shigbeard commented 10 years ago

Hmm... perhaps tie this up with agenda grouping?

On 15/4/2014 2:08 PM, fantasticaneer wrote:

I've been in a situation many times where I've wanted to be able to allow everyone in my group to be able to enter a building, beit as the don of a mob, terrorist leader, owner of a restaurant, etc, there are many possible applications for this functionality and I think it's silly that it isn't built in already.

It'd simply be an addition to the F2 menu for door owning: "Add Group Ownership". You would then be able to set a job or multiple jobs as being owners of the door until you sell it, similar to how a group can own a door already.

This would make it so much easier to make bases without outside tools like fading doors and without constantly managing the list of allowed owners to add/remove people as they change jobs.

— Reply to this email directly or view it on GitHub https://github.com/FPtje/DarkRP/issues/1413.

FPtje commented 10 years ago

Diy with hooks

fantasticaneer commented 10 years ago

How about you do it yourself? Valid improvements to the script shouldn't be brushed under the rug because you can 'do it yourself with hooks'.

This is an issue I have regularly on multiple servers running vanilla DarkRP and is an obvious major improvement with little effort required.

Shigbeard commented 10 years ago

Thats what DIY stands for.

He is saying the hooks exist, you can do it yourself

On 15/4/2014 2:52 PM, fantasticaneer wrote:

How about you do it yourself?

— Reply to this email directly or view it on GitHub https://github.com/FPtje/DarkRP/issues/1413#issuecomment-40445586.

fantasticaneer commented 10 years ago

I don't get the logic here. I could just code my own RP script too theoretically, but I'd prefer the functionality to be added to all servers, if it's so easy you could do it using a hook already in place.

mleonhard38 commented 10 years ago

Why dont you code a RP Script and make it 'Open Source' like DarkRP is?

Am Dienstag, 15. April 2014 schrieb fantasticaneer :

I don't get the logic here. I could just code my own RP script too theoretically, but I'd prefer the functionality to be added to all servers, if it's so easy you could do it using a hook already in place.

— Reply to this email directly or view it on GitHubhttps://github.com/FPtje/DarkRP/issues/1413#issuecomment-40445941 .

fantasticaneer commented 10 years ago

You could theoretically defend your home from robbers yourself if you wanted to, but the police exist because it's smarter to have the government run that instead of expecting the public to do it themselves.

There are things that make sense being handled by someone else. To expect people to just take stuff into their own hands is irresponsible and lazy.

mleonhard38 commented 10 years ago

No, you're lazy as you cant code a 5min hook yourself.

I can understand you, Im also often bringing up suggestions wich get declined. But, it's OK - cause just Imagine DarkRP would be full of dozens of small features, why should Server Owners then care about Custom Content? Every Server would be the same. If you read the Git changes, you can see Falco implemented every single suggestion wich wasn't do-able yourself in an easy way.

So please stop discussing or youre probably going to get banned if you start raging.

Am Dienstag, 15. April 2014 schrieb fantasticaneer :

You could theoretically defend your home from robbers yourself if you wanted to, but the police exist because it's smarter to have the government run that instead of expecting the public to do it themselves.

There are things that make sense being handled by someone else. To expect people to just take stuff into their own hands is irresponsible and lazy.

— Reply to this email directly or view it on GitHubhttps://github.com/FPtje/DarkRP/issues/1413#issuecomment-40446185 .

FPtje commented 10 years ago

Marcel, I do not ban people for disagreeing with me. Do not speak on my behalf.

This feature is similar to the door group system that's already implemented. The differences are that with your system anyone can set a door group and that those door groups aren't saved.

I don't think your system should be in DarkRP by default. It would confuse admins when they see two kinds of door group systems that on first sight appear to do the same thing. I made this mistake with FPP, there are tons of ways to restrict tools. I now get complaints that it's too confusing.

The point is that you can think of many systems like this:

Am I too lazy to implement them all, or is my decision to say no to this kind of functionality justified?

mleonhard38 commented 10 years ago

I mean if he would start raging, he may get a ban - and this seemed likely. Not for disagreeing.

Am Dienstag, 15. April 2014 schrieb Falco Peijnenburg :

Marcel, I do not ban people for disagreeing with me. Do not speak on my behalf.

This feature is similar to the door group system that's already implemented. The differences are that with your system anyone can set a door group and that those door groups aren't saved.

I don't think your system should be in DarkRP by default. It would confuse admins when they see two kinds of door group systems that on first sight appear to do the same thing. I made this mistake with FPP, there are tons of ways to restrict tools. I now get complaints that it's too confusing.

The point is that you can think of many systems like this:

  • share with people of the same agenda group
  • share with people of the same team
  • share with people of the same usergroup
  • share with people who have a certain amount of money/kills/deaths

Am I too lazy to implement them all, or is my decision to say no to this kind of functionality justified?

— Reply to this email directly or view it on GitHubhttps://github.com/FPtje/DarkRP/issues/1413#issuecomment-40447005 .

FPtje commented 10 years ago

I'd be a hypocrite if I did that.

Shigbeard commented 10 years ago

Look the point i see here is that it is not a "Should be in DarkRP" thing, but is infact a "Should be in your server" kind of thing.

Lets just drop the topic, and appreciate a good idea

FPtje commented 10 years ago

Drop the topic? But what if the op disagrees and still has something to say?

fantasticaneer commented 10 years ago

I'm being super hostile and I'm sorry- it's frustrating to have this feature shrugged off so immediately like you did, as though it's not even worth thinking about. If your issue is confusion - maybe it could be reworded like "Allow jobs to access your door"?

I just want this feature because I feel as though the built-in non-police groups have no way to adequately control the flow of people into their bases without an external addon like fading doors. I think right now the non-police groups (italian mafia, terrorists, etc, any group that isn't government but involves a leader and multiple people below them) have a trouble of being unorganized, and being able to easily allow people in and out of a base without using door codes or other silly business like that would be a valuable feature that people would instantly recognize and start using.

Right now you end up with a situation where most people leave their doors open and locked and then put a fading door on top of it with a keypad on the wall, causing the door to sit there annoyingly ajar and useless.

I also think your examples of other 'possible features' along the same line, you would agree, are pretty useless and don't add the same kind of functionality as my suggestion, except perhaps the agenda group one, which I think would work but not as well.

I think it opens up some fun RP opportunities, too, for example. I can make a homeless shelter and allow all the rooms to be accessed by hobos. I can make a mob base with the front door accessed by anyone in the group, but my personal office accessed by only me. The mob could try to force a shop owner to give them access and threaten them if they don't.

Shigbeard commented 10 years ago

Http://coderhire.com/

FPtje commented 10 years ago

It would still be confusion and a partial feature duplication despite the different wording.

Non-police groups don't have to use keypads. They can add people to doors, which is really easier than doing the fading door trick. Fading doors are used for "extra security" and they won't go away if this feature is added.

I can think of similar reasons to implement the other functionalities I mentioned. Take the usergroup example. That could be used for the admin rooms that some maps have. The "share with people who have a certain amount of money" could be used to create a millionaires club, rp segregation and discrimination. I'm sure people like JoeSkylynx would love that idea. (JoeSkylynx is an RP visionaire)

fantasticaneer commented 10 years ago

I tried adding people to doors manually but you get a non-sorted (as far as I remember, it might have been alphabetical but you know how hard it can be to pick one name out of a huge list) huge list of names and have to sit there staring for 10 minutes to find the right name and add someone, and then remove them manually when they leave the group. I was spending most of my time adding people and removing people from doors and eventually I got frustrated and stopped and then had people PMing me asking to be added to the doors and threw my hands up and stopped being a mob boss.

So yeah, in concept you can just add and remove people manually, but on a server with over 20 players (some servers even have 32+ players!) it just isn't feasible unless you plan on having them stay for the next 3 hours and be completely loyal to you and never change jobs, or you love doing menial busywork and staring at doors.

It also becomes twice/three times as much of a pain if you have more than one door.

Shigbeard commented 10 years ago

Ugh, the nag is unbearable... I'm gonna set up a test server and make this a thing now...

Shigbeard commented 10 years ago

Actually, I may need help with this one, if I'm going to do this the way I intend to. Off to the darkrp forum i go.

Shigbeard commented 10 years ago

While I was making this, I discovered it would be difficult to add buttons to the keys menu, due to the fact that the keys menu does not provide hooks to add your own buttons.

Unless I am missing something...

Shigbeard commented 10 years ago

Falco, I did some looking into this. It's not actually as simple as you make it sound, and the hooks for keys do not work for this. Therefor, I think that this can now be considered a bug (see #1415).

FPtje commented 10 years ago

1415 is its own issue.