search

FPtje / DarkRP

DarkRP, a non-serious roleplay gamemode for Garry's Mod.
https://darkrp.miraheze.org
MIT License
463 stars 710 forks source link

net.ReadType(net.ReadUInt(8)) should be removed #1974

Closed meepen closed 9 years ago

meepen commented 9 years ago

in quite a few instances, you do net.ReadType(net.ReadUInt(8))

this should however be removed since you use net.WriteType, which should figure out which type it is by itself, and not let the user guess how it writes it on the other side.

you should change all instaces of 

net.ReadType(net.ReadUInt(8))

to 

net.ReadType()
FPtje commented 9 years ago

Nitpicking

meepen commented 9 years ago

It's not nitpicking, I am rewriting net.Read/WriteType.

I need this to be standard so I can safely do it the right way.

If you don't change this then your gamemode will not work with the net addon, which will optimize a lot of the network functions

Bo98 commented 9 years ago

Not against this, but do remember that the net.ReadType parameter only became optional in the last update so there will be quite a lot of addons out there with the same code.

FPtje commented 9 years ago

So I wasn't even wrong in doing this.

meepen commented 9 years ago

You weren't before the update, but now that it does it automatically and you are not getting the type of the var any differently... you should probably change it

FPtje commented 9 years ago

If you are to remake the net.*Type functions, why don't you make them backwards compatible? I don't see how you should make everyone else except for yourself responsible for the changes you want to make.

meepen commented 9 years ago

How am I supposed to make it backwards compatible if I don't write a uint of 8 bits to the message?

meepen commented 9 years ago

I've put this on facepunch: http://facepunch.com/showthread.php?t=1450721&p=47913460&viewfull=1#post47913460

FPtje commented 9 years ago

One really good idea is not changing those functions. The last update gave enough trouble when it broke backwards compatibility.

You'll fucking kill gmod if every update breaks addons. Also, this is not a DarkRP specific issue. Go to the next update thread.

Jitterclick commented 9 years ago

-rep bad at lua and fat ppl play darkrp

Shigbeard commented 9 years ago

Not sure if retarded or just trolling.

Jitterclick commented 9 years ago

Not sure if Facepunch has even tried to fix your problems or no? Am i right? Garry is a fat lazy fuck who plays too much fucking rust that fat oaf

Jitterclick commented 9 years ago

And don't be nice to the assholes at face punch, they deserve all the hate they can get. Bad dev team

Shigbeard commented 9 years ago

Are you just going to shitpost or are you gonna tell us something we don't know?

Jitterclick commented 9 years ago

So you agee Facepunch are assholes, including Rocketboy?

Shigbeard commented 9 years ago

No, I agree you are a shit head.

Jitterclick commented 9 years ago

I agree you are a shit head aswell. So another dickrider or fatass? What a Snowdog?

Shigbeard commented 9 years ago

Nope, another dickhead in my ignore list.

Jitterclick commented 9 years ago

Bye Bye you must be fat or something picking on teenagers on git hub

FPtje commented 9 years ago

Fucked off

Bo98 commented 9 years ago

Sounds like someone got their issue closed at Facepunch/garrysmod-issues

Shigbeard commented 9 years ago

Nah, its just a fan boy right off the hipster train.

Bo98 commented 9 years ago

https://github.com/Facepunch/garrysmod-issues/issues/2098