FPtje / DarkRP

DarkRP, a non-serious roleplay gamemode for Garry's Mod.
https://darkrp.miraheze.org
MIT License
467 stars 710 forks source link

[Bug] Refactor - F4 menu not refreshing correctly. #955

Closed MuteTM closed 11 years ago

MuteTM commented 11 years ago

image

Download fresh install. Start listen server. Go gun dealer. Look at the job list. Every time you switch jobs, it the previous jobs disappear from the list. Also, the entity/shipments/weapons/ammo tabs also have issues refreshing, but not as blatant.

Disabling the new config option fixes the problem..

FPtje commented 11 years ago

When you change to gangster, the gangster is removed from the list, because you can't become gangster anymore. You can't become gangster when you are a gangster. YOU set the option to hide jobs you can't get. So yeah, some jobs hide.

On the other hand, if you become a CP, the Chief is suddenly added to the list, because all of a sudden you are able to become chief. It makes sense, doesn't it?

FPtje commented 11 years ago

Now the refreshing thing is something I just noticed too.

MuteTM commented 11 years ago

That's not it. Say I go gun dealer, then medic, then hobo. Citizen, Medic and Gun Dealer don't show on the list (along with hobo, of course)

FPtje commented 11 years ago

oh sorry, I got it wrong. Bug confirmed.

FPtje commented 11 years ago

Ah, both refreshing issues were caused by the same problem. It hid the items, but it never showed them again.

It was a regression that occurred when adding that option. (regression = something that used to work, but stopped working after an update)

MuteTM commented 11 years ago

Alright, thanks for the explanation.